bpo-37878: PyThreadState_DeleteCurrent() was not removed #20489
Conversation
Update What's New in Python 3.9.
|
Issue reported at #15315 (comment) |
|
Should you mention that it has been moved? There is a section below about changes to the limited ABI that it might fit in. If PyBind11 is the only user, though, we already know that. :) |
Done.
I don't understand why you mention PyBind11 here. In #15315 (comment) you wrote that PyBind11 does not use the limited C API. So PyBind11 is not impactd by https://bugs.python.org/issue37878 changes, right? You also wrote "Now that 3.9b1 is out, PyBind11-based libraries cannot build" but you didn't explain what is your error. I don't understand what are you expecting? Do you want to move back the function to the limited C API? Does Pybind11 use the limited C API or not? It's unclear. |
|
It needs to make sure it includes the correct header since this has moved, but otherwise, it does not need to change. PyBind11 does not use the limited API. There is currently a different issue as well, but I think I was only tripping up on a deprecated warning and falling to compile because I had warnings as errors. I'm setting up a PyBind11 CI build on Python 3.9 and so far it looks promising. I don't think there's an issue from the Python side. Thanks! |
Include/cpython/pystate.h is included automatically by Include/pystate.h and cannot be included directly (it fails with a compilation error). |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
) Update What's New in Python 3.9. PyThreadState_DeleteCurrent was not removed, but excluded from the limited C API. (cherry picked from commit fda7f6d) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-20496 is a backport of this pull request to the 3.9 branch. |
* 'master' of github.com:python/cpython: (497 commits) bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748) bpo-40798: Generate a different message for already removed elements (pythonGH-20483) closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149) bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951) bpo-29882: Add an efficient popcount method for integers (python#771) Further de-linting of zoneinfo module (python#20499) bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435) Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509) bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620) bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448) bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494) Note the output ordering of combinatoric functions (pythonGH-19732) bpo-40474: Updated coverage.yml to better report coverage stats (python#19851) bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492) bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332) bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489) bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493) bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339) bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177) bpo-40275: Fix test.support.threading_helper (pythonGH-20488) ...
Update What's New in Python 3.9.
https://bugs.python.org/issue37878